Skip to content

[ET-VK][ez] Make get_tensor() API protected #13097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[ET-VK][ez] Make get_tensor() API protected #13097

wants to merge 2 commits into from

Conversation

@SS-JIA
Copy link
Contributor

@SS-JIA SS-JIA commented Aug 4, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Changes

As title; make the get_tensor() API protected.

Motivation

See the below diff/PR in the stack. The goal is to encourage operator authors to go through the ComputeGraph to access/modify tensors so that the activity can be tracked.

Differential Revision: D79564596

@SS-JIA
[ET-VK][ez] Make get_tensor() API protected
bbe30ad 
## Changes

As title; make the `get_tensor()` API protected.

## Motivation

See the below diff/PR in the stack. The goal is to encourage operator authors to go through the `ComputeGraph` to access/modify tensors so that the activity can be tracked.

Differential Revision: [D79564596](https://our.internmc.facebook.com/intern/diff/D79564596/)

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 4, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13097

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 3 New Failures, 1 Unrelated Failure

As of commit 78a1dbc with merge base ec35f56 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Aug 4, 2025
Closed
Closed
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 4, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D79564596

@github-actions
Copy link

github-actions bot commented Aug 4, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@SS-JIA
Update on "[ET-VK][ez] Make get_tensor() API protected"
78a1dbc 
## Changes

As title; make the `get_tensor()` API protected.

## Motivation

See the below diff/PR in the stack. The goal is to encourage operator authors to go through the `ComputeGraph` to access/modify tensors so that the activity can be tracked.

Differential Revision: [D79564596](https://our.internmc.facebook.com/intern/diff/D79564596/)

[ghstack-poisoned]
@SS-JIA SS-JIA mentioned this pull request Aug 4, 2025
Closed
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D79564596

@SS-JIA SS-JIA closed this Aug 29, 2025
@SS-JIA SS-JIA deleted the gh/SS-JIA/264/head branch October 15, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SS-JIA @facebook-github-bot